ci(NODE-5424): add CI testing for FLE 6.0 with driver latest #3802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
added
the
Primary Review
durran
requested changes
Aug 10, 2023
|
After https://mongodb.slack.com/archives/GGWBN4ZNK/p1691521646939079, I created the 6.0 branch. We'll just need to rebase it once 6.0 is released. You can see it's already running CI when libmongocrypt commits. The only task left (and something I had to ask the evergreen team for help for) was limiting which tasks run on the waterfall to only the custom csfle tests. evergreen project: https://spruce.mongodb.com/commits/node-mongodb-native-6.0?view=FAILED |
durran
approved these changes
Aug 10, 2023
durran
added
Team Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
To prepare for the 6.0 release and the compatabilty matrix between mongodb-client-encryption and the driver, I added a task to our CI that tests the latest driver changes against mongodb-client-encryption@6.0.0. This task runs for all regular CI runs as a part of the custom csfle tests.
I also pulled in the latest alpha of mongodb-client-encryption for all CI runs except the new variant.
To confirm that the new task was running against the correct version of
mongodb-client-encryption, I added the version of mongodb-client-encryption used (if it's available) to the printout before mocha CI runs. This affects all CI runs but I believe this is a useful improvement. Here is an example: https://parsley.mongodb.com/evergreen/mongo_node_driver_next_rhel80_large_Node20_test_4.4_sharded_cluster_patch_51a573fe99506b81c7ab808898eb9eb63f58f600_64d3af041e2d171079fd9bc0_23_08_09_15_21_41/0/task?bookmarks=0,7369&shareLine=545Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript